RFR: 8344165: Trace exceptions with a complete call-stack [v8]
Ioi Lam
iklam at openjdk.org
Tue Jun 17 06:02:30 UTC 2025
On Tue, 17 Jun 2025 05:29:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @dholmes-ora comments -- removed printing of output.getStdout() from test
>
> src/hotspot/share/gc/serial/serialHeap.cpp line 549:
>
>> 547:
>> 548: // Whenever a GC happens, clear the exception logging cache to avoid stale oop pointers.
>> 549: Exceptions::clear_logging_cache();
>
> Shouldn't we do this prior to the GC to be extra-safe?
I am not sure where I can catch the beginning of every GC. I added the code in this function as it's called whenever the GC is going to trace or relocate all global roots, so it seems to be a good place to clear the cache (which is kind of like a global root).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25522#discussion_r2151386568
More information about the hotspot-dev
mailing list