RFR: 8356556: AArch64: No need for acquire fence in safepoint poll in FFM [v2]

[Anton Artemov]

On Tue, 17 Jun 2025 05:10:30 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8356556: Addressed reviewers' comments.
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 558:
> 
>> 556: void MacroAssembler::safepoint_poll(Label& slow_path, bool at_return, bool in_nmethod, Register tmp) {
>> 557: 
>> 558:   // No need for acquire fence as java threads disarm themselves, ldar not needed.
> 
> The comment explains the difference between the old and new code, but loses that context outside of the PR. I don't think you need to say anything here.

Agree, addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25829#discussion_r2151528412