RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v41]

[Afshin Zafari]

On Tue, 17 Jun 2025 15:53:04 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixes to a few failures.
>
> test/hotspot/gtest/runtime/test_virtualMemoryTracker.cpp line 259:
> 
>> 257:   static void test_add_committed_region_overlapping() {
>> 258:     RegionsTree* rtree = VirtualMemoryTracker::Instance::tree();
>> 259:     rtree->tree().remove_all();
> 
> Why are we calling `remove_all()` right after we create the tree?

We are not creating the tree here. We just retrieve it from the Instance of VMT. Since the tree is also visible to other tests (it is static and not created per test), any changes in other tests will be visible here by this test. This is not as expected in the design of the tests (tests assume that tree is empty at the beginning of the test).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r2154087590