RFR: 8268406: Deallocate jmethodID native memory [v4]

[Coleen Phillimore]

On Tue, 17 Jun 2025 23:34:42 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use load_acquire only in the places that need it.
>
> src/hotspot/share/oops/instanceKlass.cpp line 2412:
> 
>> 2410: }
>> 2411: 
>> 2412: // Lookup or create a jmethodID
> 
> Nit: Add dot at the end.

fixed.

> src/hotspot/share/oops/jmethodIDTable.hpp line 48:
> 
>> 46:   static void remove(jmethodID mid);
>> 47: 
>> 48:   // RedefineClasses support
> 
> Nit: Add a dot at the end of the comment for consistency with other comments.

This isn't a sentence and this pattern is in the sources in a lot of places, none of these places have a period at the end.

> src/hotspot/share/oops/method.hpp line 718:
> 
>> 716: 
>> 717:   static void change_method_associated_with_jmethod_id(jmethodID old_jmid_ptr, Method* new_method);
>> 718:   static bool validate_method_id(jmethodID mid);
> 
> Nit: I'd suggest to name it `validate_jmethod_id` for consistency.

Good suggestion - these names get confusing without the 'j'.  I tried to make them consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25267#discussion_r2154417361
PR Review Comment: https://git.openjdk.org/jdk/pull/25267#discussion_r2154420659
PR Review Comment: https://git.openjdk.org/jdk/pull/25267#discussion_r2154422068