RFR: 8357220: Introduce a BSMAttributeEntry struct [v6]

Johan Sjölen jsjolen at openjdk.org
Thu Jun 19 08:03:22 UTC 2025


On Thu, 19 Jun 2025 07:33:46 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Double check your changes next time!
>
> src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp line 414:
> 
>> 412:     write_u2(num_bootstrap_arguments);
>> 413:     for (int arg = 0; arg < num_bootstrap_arguments; arg++) {
>> 414:       u2 bootstrap_argument = cpool()->bsm_attribute_entry(n)->argument_index(arg);
> 
> Nit: This line can also use the `bsme` local: `u2 bootstrap_argument = bsme->argument_index(arg);`
> Sorry, I missed this before.

Thanks, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25298#discussion_r2156382285


More information about the hotspot-dev mailing list