RFR: 8360023: Add an insertion sort implementation to Hotspot [v2]

[Evgeny Astigeevich]

On Thu, 19 Jun 2025 11:39:56 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This PR adds an implementation of insertion sort to Hotspot. It is an algorithm that is inplace and stable, and it is the ideal algorithm for arrays with small numbers of elements. The motivation for this is [JDK-8357186](https://bugs.openjdk.org/browse/JDK-8357186) in which a stable sort is desired and the number of elements is small.
>> 
>> In addition, I make some improvements to `GrowableArrayIterator`:
>> 
>> - Make a non-const variant (our current iterator is const only).
>> - Add various utility operators to align with a typical iterator.
>> 
>> [JDK-8360032](https://bugs.openjdk.org/browse/JDK-8360032) is a follow-up work that will build a stable merge-insertion sort on top of this PR.
>> 
>> Please take a look and share your thoughts. Thanks very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix windows build failures

src/hotspot/share/utilities/growableArray.hpp line 198:

> 196:   }
> 197: 
> 198:   GrowableArrayIterator<E, false> ncend() {

I don't think `ncbegin` and `ncend` are good names. Why not to use `begin` and `end`?
Also `GrowableArrayIterator<E, false>` looks confusing because of the second parameter. 
Why not to use something like `GrowableArrayConstIterator`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25895#discussion_r2157042350