RFR: 8360023: Add an insertion sort implementation to Hotspot [v2]

[Quan Anh Mai]

On Thu, 19 Jun 2025 13:36:53 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix windows build failures
>
> src/hotspot/share/utilities/growableArray.hpp line 198:
> 
>> 196:   }
>> 197: 
>> 198:   GrowableArrayIterator<E, false> ncend() {
> 
> I don't think `ncbegin` and `ncend` are good names. Why not to use `begin` and `end`?
> Also `GrowableArrayIterator<E, false>` looks confusing because of the second parameter. 
> Why not to use something like `GrowableArrayConstIterator`?

Because it would be an incompatible change, there are places where we do things like

    GrowableArrayIterator<E> it = array.begin();

I think your latter concern can be addressed by `using GrowableArrayNonConstIterator`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25895#discussion_r2157121474