RFR: 8360023: Add an insertion sort implementation to Hotspot [v3]
Evgeny Astigeevich
eastigeevich at openjdk.org
Thu Jun 19 15:38:29 UTC 2025
On Thu, 19 Jun 2025 14:27:06 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hi,
>>
>> This PR adds an implementation of insertion sort to Hotspot. It is an algorithm that is inplace and stable, and it is the ideal algorithm for arrays with small numbers of elements. The motivation for this is [JDK-8357186](https://bugs.openjdk.org/browse/JDK-8357186) in which a stable sort is desired and the number of elements is small.
>>
>> In addition, I make some improvements to `GrowableArrayIterator`:
>>
>> - Make a non-const variant (our current iterator is const only).
>> - Add various utility operators to align with a typical iterator.
>>
>> [JDK-8360032](https://bugs.openjdk.org/browse/JDK-8360032) is a follow-up work that will build a stable merge-insertion sort on top of this PR.
>>
>> Please take a look and share your thoughts. Thanks very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>
> GrowableArrayNonConstIterator
Here the simple implementation which does not require a lot of code:
```c++
void GrowableArrayView<>::insertion_sort(int f(E*, E*)) {
if (_data == nullptr) return;
for (int i = 1; i < length(); i++) {
E key = _data[i];
int j = i - 1;
while (j >= 0 && f(_data[j], key)) {
_data[j + 1] = _data[j];
j--;
}
_data[j + 1] = key;
}
}
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25895#issuecomment-2988517979
More information about the hotspot-dev
mailing list