RFR: 8360023: Add an insertion sort implementation to Hotspot [v6]

Andrew Haley aph at openjdk.org
Fri Jun 20 08:33:29 UTC 2025


On Fri, 20 Jun 2025 03:09:00 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This PR adds an implementation of insertion sort to Hotspot. It is an algorithm that is inplace and stable, and it is the ideal algorithm for arrays with small numbers of elements. The motivation for this is [JDK-8357186](https://bugs.openjdk.org/browse/JDK-8357186) in which a stable sort is desired and the number of elements is small. Additionally, since insertion sort is the most efficient sorting algorithm for small arrays, it can be used in non-stable sort as well.
>> 
>> In addition, I make some improvements to `GrowableArrayIterator`:
>> 
>> - Make a non-const variant (our current iterator is const only).
>> - Add various utility operators to align with a typical iterator.
>> 
>> [JDK-8360032](https://bugs.openjdk.org/browse/JDK-8360032) is a follow-up work that will build a stable merge-insertion sort on top of this PR.
>> 
>> Please take a look and share your thoughts. Thanks very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comment

src/hotspot/share/utilities/sort.hpp line 52:

> 50:       T* pos = current;
> 51:       while (pos > begin) {
> 52:         // Since the sort is stable, we must insert the current element at the first location at

Suggestion:

        // Because the sort is stable, we must insert the current element at the first location at

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25895#discussion_r2158346057


More information about the hotspot-dev mailing list