RFR: 8344165: Trace exceptions with a complete call-stack [v9]
Ioi Lam
iklam at openjdk.org
Fri Jun 20 21:31:13 UTC 2025
On Fri, 20 Jun 2025 18:21:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - refactor
>> - Reimplement -- print stack trace only when it is a known throwing site
>
> src/hotspot/share/utilities/exceptions.cpp line 635:
>
>> 633: // and Exceptions::_throw()).
>> 634: void Exceptions::log_exception_stacktrace(Handle exception, methodHandle method, int bci) {
>> 635: if (method->is_native() || (Bytecodes::Code) *method->bcp_from(bci) == Bytecodes::_athrow) {
>
> Do you mean !method->is_native() && athrow? How do you get here from a native method ?
I fixed it. I thought we could get there with a native method, but looking at `InterpreterRuntime::exception_handler_for_exception()`, we can't.
Anyway, I left the `!method->is_native()` there just for safety.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25522#discussion_r2159683183
More information about the hotspot-dev
mailing list