RFR: 8356865: C2: Unreasonable values for debug flag FastAllocateSizeLimit can lead to left-shift-overflow, which is UB [v4]

[Emanuel Peter]

On Mon, 23 Jun 2025 07:09:15 GMT, Benoît Maillard <bmaillard at openjdk.org> wrote:

>> This PR adds a range constraint for the `-XX:FastAllocateSizeLimit` debug flag. This prevents undefined behavior caused by left-shift overflow of the flag value in `GraphKit::new_array`.
>> 
>> ### Testing
>> - [x] [GitHub Actions](https://github.com/benoitmaillard/jdk/actions?query=branch%3AJDK-8356865)
>> - [x] tier1-3, plus some internal testing
>> - [x] Manual testing with values known to previously cause undefined behavior
>> 
>> Thanks!
>
> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8356865: Add comment for range in test

Thanks for the updates! Nice work :)

-------------

Marked as reviewed by epeter (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25834#pullrequestreview-2948981657