RFR: 8359920: Use names for frame types in stackmaps [v5]
Coleen Phillimore
coleenp at openjdk.org
Mon Jun 23 12:06:03 UTC 2025
On Mon, 23 Jun 2025 12:02:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This uses names for frame types for stackmaps in the verifier and redefinition.
>> Tested with tier1-7.
>
> Coleen Phillimore has updated the pull request incrementally with three additional commits since the last revision:
>
> - Update src/hotspot/share/prims/jvmtiRedefineClasses.cpp
>
> Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
> - Update src/hotspot/share/classfile/stackMapTable.cpp
>
> Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
> - Update src/hotspot/share/classfile/stackMapTable.cpp
>
> Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
Yes, I like all of these changes. One would have prevented me from a transient bug I had. @matias9927 and I chatted about restructuring this code in the future which seems like a good idea. All in all, these tags and your suggestions are really helpful.
Also verified and am testing your suggested changes.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25870#pullrequestreview-2949819071
More information about the hotspot-dev
mailing list