RFR: 8344165: Trace exceptions with a complete call-stack [v10]

[Coleen Phillimore]

On Mon, 23 Jun 2025 06:06:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @coleenp comments; Also, use ProcessTools.executeProcess() to log the output in files
>
> src/hotspot/share/utilities/exceptions.cpp line 637:
> 
>> 635:   if (!method->is_native() && (Bytecodes::Code) *method->bcp_from(bci) == Bytecodes::_athrow) {
>> 636:     // TODO: it would be nice to filter out exceptions re-thrown by finally blocks (which include
>> 637:     // try-with-resource statements):
> 
> This mega-comment really doesn't belong here. Please ensure this discussion is in JBS and just use a short comment here e.g.
> 
> // TODO: try to find a way to avoid repeated stacktraces when an exception gets re-thrown by a finally block

Thank you - I made this comment to Ioi privately and would really like to see it removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25522#discussion_r2161501057