RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

Anton Artemov duke at openjdk.org
Tue Jun 24 09:18:17 UTC 2025


On Mon, 23 Jun 2025 15:48:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8359437: Addressed reviewers' comments
>>  - 8359437: Addressed reviewers' comments
>
> test/jdk/java/lang/Thread/virtual/Parking.java line 388:
> 
>> 386:     @ParameterizedTest
>> 387:     @ValueSource(booleans = { true, false })
>> 388:     @DisabledIf("LockingMode#isLegacy")
> 
> Would you mind checking if the import DisabledIf can be removed from these tests? I think we only used it to conditionally run when not legacy mode.

That imports became unused everywhere, so I removed them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2163397316


More information about the hotspot-dev mailing list