RFR: 8359437: Make users and test suite not able to set LockingMode flag [v2]

Anton Artemov duke at openjdk.org
Tue Jun 24 09:59:51 UTC 2025


On Tue, 24 Jun 2025 09:14:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8359437: Addressed reviewers' comments
>>  - 8359437: Addressed reviewers' comments
>
> test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 80:
> 
>> 78:             monitors[index] = new Object();
>> 79:             synchronized (monitors[index]) {
>> 80:                 WB.forceInflateMonitorLockedObject(monitors[index]);
> 
> This is now the only use of the new WB method and we can replace this with a simple:
> 
> monitors[index].wait(1);
> 
> as the `wait` forces inflation. Then we can deleted the new WB stuff.

Good catch! It required adding try/catch to the test as `wait()` is throwing `InterruptedException`, addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2163501835


More information about the hotspot-dev mailing list