RFR: 8360474: Add missing include guards for some HotSpot headers [v2]
Coleen Phillimore
coleenp at openjdk.org
Wed Jun 25 11:13:28 UTC 2025
On Wed, 25 Jun 2025 08:13:43 GMT, Qizheng Xing <qxing at openjdk.org> wrote:
>> Some HotSpot header files are missing include guards, which may cause compilation errors if these files are included multiple times. This patch adds include guards for them.
>
> Qizheng Xing has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove extra trailing new line
src/hotspot/share/utilities/packedTable.hpp line 27:
> 25: #ifndef SHARE_UTILITIES_PACKEDTABLE_HPP
> 26: #define SHARE_UTILITIES_PACKEDTABLE_HPP
> 27:
I just backported this to JDK 25. I wonder if you should omit this change and put it under another CR so we can backport that too. Or not backport this, assuming that JDK 25 will never have double inclusions of this file ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25968#discussion_r2166454866
More information about the hotspot-dev
mailing list