RFR: 8360474: Add missing include guards for some HotSpot headers [v2]
Qizheng Xing
qxing at openjdk.org
Thu Jun 26 01:58:32 UTC 2025
On Wed, 25 Jun 2025 11:10:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Qizheng Xing has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove extra trailing new line
>
> src/hotspot/share/utilities/packedTable.hpp line 27:
>
>> 25: #ifndef SHARE_UTILITIES_PACKEDTABLE_HPP
>> 26: #define SHARE_UTILITIES_PACKEDTABLE_HPP
>> 27:
>
> I just backported this to JDK 25. I wonder if you should omit this change and put it under another CR so we can backport that too. Or not backport this, assuming that JDK 25 will never have double inclusions of this file ?
Can I backport the entire PR to JDK 25 instead of splitting it up? I noticed that all the changes can be applied to JDK 25 as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25968#discussion_r2167937010
More information about the hotspot-dev
mailing list