RFR: 8359437: Make users and test suite not able to set LockingMode flag [v5]

Alan Bateman alanb at openjdk.org
Thu Jun 26 05:59:36 UTC 2025


On Wed, 25 Jun 2025 11:35:51 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> test/jdk/jdk/internal/vm/Continuation/Fuzz.java line 477:
>> 
>>> 475:     boolean shouldPin() {
>>> 476:         // Returns false since we never pin after we removed legacy locking.
>>> 477:         return traceHas(Op.PIN::contains) && false;
>> 
>> Are you planning to remove this method and update verifyPin, or maybe there will be a follow-on JBS issue for this cleanup?
>
> Removal will be done in phase 2.

Next phase is okay too, just need to remember as it will be confusing for a time to have it return false unconditionally.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2168188065


More information about the hotspot-dev mailing list