RFR: 8344165: Trace exceptions with a complete call-stack [v13]
Ioi Lam
iklam at openjdk.org
Thu Jun 26 17:26:39 UTC 2025
On Thu, 26 Jun 2025 11:43:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>>
>> - Merge branch 'master' into 8358080-print-thread-stack-with-xlog-exceptions-trace
>> - Fix crash in runtime/logging/RedefineClasses.java: cannot print stack trace in Exceptions::special_exception()
>> - @coleenp comments: Removed dead code
>> - @coleenp and @dholmes-ora comments
>> - @coleenp comments; Also, use ProcessTools.executeProcess() to log the output in files
>> - refactor
>> - Reimplement -- print stack trace only when it is a known throwing site
>> - @dholmes-ora comments -- removed printing of output.getStdout() from test
>> - Print callstack for rethrown exceptions
>> - @dholmes-ora comments - use JavaThread::current() instead
>> - ... and 5 more: https://git.openjdk.org/jdk/compare/043d2636...3eb7c622
>
> Looks good and it'll be really helpful.
Thanks @coleenp and @dholmes-ora for the review
Passed tiers1-4 and build-tiers-5
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25522#issuecomment-3009211576
More information about the hotspot-dev
mailing list