RFR: 8358680: AOT cache creation fails: no strings should have been added [v2]

[Ioi Lam]

On Tue, 17 Jun 2025 17:03:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8358680-aot-cache-creation-fails-with-no-strings-should-have-been-added
>>  - @coleenp comment: change items_count() to items_count_acquire()
>>  - 8358680: AOT cache creation fails: no strings should have been added
>
> src/hotspot/share/classfile/stringTable.cpp line 351:
> 
>> 349: }
>> 350: 
>> 351: size_t StringTable::items_count() {
> 
> I think there's a convention to make accessor functions that use acquire semantics to be named items_count_acquire().

I changed to items_count_acquire().

> src/hotspot/share/classfile/stringTable.cpp line 970:
> 
>> 968:   // This flag will be cleared after intern table dumping has completed, so we can run the
>> 969:   // compiler again (for future AOT method compilation, etc).
>> 970:   DEBUG_ONLY(Atomic::release_store(&_disable_interning_during_cds_dump, 1));
> 
> I think atomics work with bool or is this a refcount ?

I tried to changed to a `bool` but Atomics doesn't like that. I got an compilation error.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25816#discussion_r2172319083
PR Review Comment: https://git.openjdk.org/jdk/pull/25816#discussion_r2172318768