RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v32]

Johan Sjölen jsjolen at openjdk.org
Sat Mar 1 22:30:05 UTC 2025


On Fri, 28 Feb 2025 19:54:48 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> There is coding style that the last enum member counts the number of them, like what we have `mt_number_of_tags` in `MemTag` enum. 
>> So, I renamed the last member to `st_number_of_states`. Would it be OK? Or preferred to use constant separately.
>
> Just because we do something already in Hotspot, doesn't necessarily mean that we should repeat the pattern going forward.
> 
> I flagged it and I really don't like it, if you guys are OK with it, I will let it be.

I'm fine with either

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1976501256


More information about the hotspot-dev mailing list