RFR: 8346916: [REDO] align_up has potential overflow [v3]

Mon Mar 3 16:57:13 UTC 2025

On Mon, 3 Mar 2025 13:52:06 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Changed it to this now
>
> Thank you; my suggestion was insufficient... Need to have an early-return when `uncommitted_size` is 0 at the beginning of `PSOldGen::expand`. After this, I wonder if `align_up_or_min` is truly warranted.

Added the extra check, tests should now work as expected!

I agree with your thoughts on `align_up_or_min`. Since it's no longer used, I went ahead and removed it. Now we. only have `align_up_or_null` left for pointer types.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23711#discussion_r1977853877