RFR: 8343840: Rewrite the ObjectMonitor lists [v2]
Fredrik Bredberg
fbredberg at openjdk.org
Wed Mar 5 12:43:03 UTC 2025
On Mon, 3 Mar 2025 23:12:05 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update after review by David and Coleen.
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1509:
>
>> 1507: // is no successor, so it appears that an heir-presumptive
>> 1508: // (successor) must be made ready. Only the current lock owner can
>> 1509: // detach threads from the entry_list, therefore we need to
>
> We don't detach threads here, so maybe manipulate would be better.
Maybe, but manipulate may also include "pushing to the head", which is fine to do without holding the lock.
I'll keep the comment as is for now, maybe this sentence will be deleted if we find a way of running exit without holding the lock, as we have talked about. If that's not possible I'll rephrase this sentence in a follow up PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23421#discussion_r1981325861
More information about the hotspot-dev
mailing list