RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v35]
Johan Sjölen
jsjolen at openjdk.org
Fri Mar 7 10:14:12 UTC 2025
On Fri, 7 Mar 2025 08:36:14 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> src/hotspot/share/nmt/virtualMemoryTracker.hpp line 49:
>>
>>> 47: // - uncommitted size of a MemTag should be <= of its committed size
>>> 48: // - released size of a MemTag should be <= of its reserved size
>>> 49:
>>
>> I don't believe that these are checked, right? So this can be deleted.
>
> As said at the end of line, when they are applied to the VirtualMemorySummary they will be checked.
> Is it OK if I limit/wrap the comments to 80-columns text?
Aha, that's when they're checked. Feel free to do so if you want, but I don't see any problem with going above 80 columns.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1984798716
More information about the hotspot-dev
mailing list