RFR: 8350642: Interpreter: Upgrade CountBytecodes to 64 bit on 64 bit platforms [v2]

[Aleksey Shipilev]

On Mon, 10 Mar 2025 10:24:44 GMT, David Linus Briemann <duke at openjdk.org> wrote:

>> 8350642: Interpreter: Upgrade CountBytecodes to 64 bit on 64 bit platforms
>
> David Linus Briemann has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
> 
>  - remove CountBytecodesTest from tier1
>  - Merge branch 'master' into dlb/bytecode_counter_overflow
>  - remove auto included header
>  - fix x86 asm
>  - address review comment, add back comma to copyright header
>  - formatting
>  - remove bad header
>  - add missing comma to copyright header
>  - speed up runtime by running less bytecodes, add explanation
>  - add copyright header and @bug number
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/d09a328b...31a52156

This looks fine to me, with a few nits, thanks.

x86_32 parts would go away as we cleanup after x86_32 removal, but they can stay here for completeness and backportability.

src/hotspot/share/interpreter/bytecodeTracer.cpp line 132:

> 130:       st->print("[%zu] ", Thread::current()->osthread()->thread_id_for_printing());
> 131:       if (Verbose) {
> 132:         st->print("%8zu  %4d  " INTPTR_FORMAT " " INTPTR_FORMAT " %s",

Sounds like there are more than 8 digits now?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23766#pullrequestreview-2675109785
PR Review Comment: https://git.openjdk.org/jdk/pull/23766#discussion_r1989582658