RFR: 8351949: RISC-V: Cleanup and enable store-load peephole for membars

Robbin Ehn rehn at openjdk.org
Fri Mar 14 07:57:55 UTC 2025


On Fri, 14 Mar 2025 07:19:55 GMT, Fei Yang <fyang at openjdk.org> wrote:

> In naming, can we use names like `_rvtso` instead of `_tso` which I think maps better to `_rvwmo`? I think it's OK as I read this from the RV spec which also mentions RVTSO:

Yes, sure.

Also please run some jcstress on any machine you have!

> src/hotspot/cpu/riscv/riscv.ad line 7982:
> 
>> 7980: 
>> 7981:   format %{ "membar_rvwmo_storestore\n\t"
>> 7982:             "fence rw, w" %}
> 
> Shouldn't this be `"fence w, w"`?

Yes, thanks. Copy paste issue :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24035#issuecomment-2723904466
PR Review Comment: https://git.openjdk.org/jdk/pull/24035#discussion_r1995040006


More information about the hotspot-dev mailing list