RFR: 8351949: RISC-V: Cleanup and enable store-load peephole for membars [v2]
Robbin Ehn
rehn at openjdk.org
Mon Mar 17 12:35:42 UTC 2025
On Mon, 17 Mar 2025 02:06:46 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments
>
> src/hotspot/cpu/riscv/riscv.ad line 7888:
>
>> 7886: // ZTSO
>> 7887:
>> 7888: instruct no_membar_rvtso() %{
>
> Can we rename this as `unnecessary_membar_rvtso` which is similar to other names like `unnecessary_membar_volatile_rvtso`? I personally don't really like the `no_` prefix.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24035#discussion_r1998631550
More information about the hotspot-dev
mailing list