RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]
Volodymyr Paprotski
vpaprotski at openjdk.org
Mon Mar 17 22:32:02 UTC 2025
On Mon, 10 Mar 2025 23:07:45 GMT, Volodymyr Paprotski <vpaprotski at openjdk.org> wrote:
>> test/jdk/com/sun/security/util/math/intpoly/MontgomeryPolynomialFuzzTest.java line 30:
>>
>>> 28: import sun.security.util.math.intpoly.*;
>>> 29:
>>> 30: /*
>>
>> It is strange that there are two copies of the `@test` block. Can you please remove one of them, unless you are seeing a difference that I do not
>
> -XX:+/-UseIntPolyIntrinsics (test Java vs BigInt and intrinsic vs BigInt)
>
> Though I think I did this before I knew much about junit.. I think I can just have two @run commands (to make it clearer)? Will give that a try
Turns out I do need both `@test`; (otherwise `make test TEST=...MontgomeryPolynomialFuzzTest.java` runs fewer tests). Seems other tests do the same.
I did add a (better?) comment to the summary tag.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23719#discussion_r1999760302
More information about the hotspot-dev
mailing list