RFR: 8352218: RISC-V: Zvfh requires RVV [v2]

[Robbin Ehn]

On Thu, 20 Mar 2025 14:53:37 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - hwprobe deps
>>  - Merge branch 'master' into maxvector_0
>>  - Moved to common
>>  - Disable UseZvfh when no RVV
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 92:
> 
>> 90:   void update_flag() {                     \
>> 91:       assert(enabled(), "Must be.");       \
>> 92:       if (FLAG_IS_DEFAULT(flag)) {         \
> 
> As this patch introduces a way to automatically disable a flag based on its dependant flag, this could introduce potential issue if the expected order is not guarantee when writing the code. It's better to have an assert there, this could be acheive by just using the existing `_value`, e.g. 
> `assert(dep.value() != -1);`
> Or maybe it's better to introduce a new field like `initialized`?

You can check that in compile time with:
`STATIC_ASSERT(offsetof(VM_Version, ext_ZvXX) > offsetof(VM_Version, ext_V));`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24094#discussion_r2005922100