RFR: 8346931: Replace divisions by zero in sharedRuntimeTrans.cpp [v2]
    Kim Barrett 
    kbarrett at openjdk.org
       
    Mon Mar 24 05:41:10 UTC 2025
    
    
  
On Fri, 21 Mar 2025 13:39:55 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> There are a few divisions by zero in sharedRuntimeTrans.cpp, used to "construct" NaN and -infinity. This should probably be replaced by using functionality from std::numeric_limits .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   replace more divisons by 0
src/hotspot/share/runtime/sharedRuntimeTrans.cpp line 518:
> 516:       z = ax;                   /*x is +-0,+-inf,+-1*/
> 517:       if(hy<0) {
> 518:         if (z == 0.0) {
Maybe s/z == 0.0/ix == 0/ ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24136#discussion_r2009490209
    
    
More information about the hotspot-dev
mailing list