RFR: 8351151: Clean up x86 template interpreter after 32-bit x86 removal

Coleen Phillimore coleenp at openjdk.org
Wed Mar 26 19:45:22 UTC 2025


On Wed, 26 Mar 2025 11:51:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> x86 template interpreter carries `_LP64`-predicated code blocks that were supporting 32-bit x86. With that port gone, we can clean up the x86 template interpreter. I have checked no superfluous `LP64`, `AMD64`, `IA32` defines are left in affected files.
> 
> Where obvious, I inlined `r15_thread` and `c_arg*`. Left the uses that assign these args to symbolic locals that have meaningful names.
> 
> `verify_FPU` is also no-op now, removed that. There are related cleanups in compilers and runtime we need to do first, before we fully remove `VerifyFPU` flag. This change fans out a little to other platform template interpreters to remove `verify_FPU` as well.
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, `tier1`
>  - [x] Linux x86_64 server fastdebug, `all`

Looks good.  Lots of changes but it was worth combining 32 and 64 bits 10 years ago.

Date:   Fri Mar 13 15:16:07 2015 -0400
    8074717: Merge interp_masm files for x86 _32 and _64

Thank you for doing this!

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24251#pullrequestreview-2718451921


More information about the hotspot-dev mailing list