RFR: 8351491: Add info from release file to hserr file [v2]
David Holmes
dholmes at openjdk.org
Thu Mar 27 04:34:07 UTC 2025
On Wed, 26 Mar 2025 15:11:06 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> The release file of the JDK image contains useful info, for example the SOURCE used to built this image e.g.
>> SOURCE=".:git:21af8c7e7405"
>> Also the MODULES list is probably useful to have.
>> Add this info (or the complete content of the release file) to the hs_err files.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> address Windows issues
If we really think we want this then maybe we should adjust the build process so that this info gets built into the binaries and doesn't require reading from the file system?
src/hotspot/share/runtime/arguments.cpp line 3665:
> 3663:
> 3664: // cache the release file of the JDK image
> 3665: os::read_image_release_file();
What is the impact on startup?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24244#issuecomment-2756644666
PR Review Comment: https://git.openjdk.org/jdk/pull/24244#discussion_r2015617670
More information about the hotspot-dev
mailing list