RFR: 8352762: Use EXACTFMT instead of expanded version where applicable
David Holmes
dholmes at openjdk.org
Thu Mar 27 05:03:06 UTC 2025
On Tue, 25 Mar 2025 13:59:14 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) introduced the EXACTFMT macro, which is a shorthand for printing exact values using methods defined in globalDefinitions.hpp. There are currently 20 places in HotSpot which uses the expanded version of the macro, along with the "trace_page_size_params" macro that is defined and used in os.cpp.
>
> I have replaced places that use the expanded macro(s) with EXACTFMT + EXACTFMTARGS, and also removed trace_page_size_params from os.cpp, which was essentially a redefnition of EXACTFMTARGS.
>
> Testing: GHA, tiers 1-4
This looks very consistent and reasonable to me.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24228#pullrequestreview-2719664900
More information about the hotspot-dev
mailing list