RFR: 8352645: Add tool support to check order of includes [v2]

[Doug Simon]

On Thu, 27 Mar 2025 05:56:55 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   drop extra blank lines and preserve rule for first include in .inline.hpp files
>
> test/hotspot/jtreg/sources/SortIncludes.java line 39:
> 
>> 37: 
>> 38: public class SortIncludes {
>> 39:     private static final String INCLUDE_LINE = "^ *#include *(<[^>]+>|\"[^\"]+\") *$\\n";
> 
> There are files that have spaces between the `#` and `include`.  I'm kind of inclined to suggest we fix those
> at some point (not in this PR).  But the regex here needs to allow for that possibility, and perhaps (eventually)
> complain about such.

Since there are no such cases in the files processed in this PR, I'd suggest not adding support for them. They can be fixed in follow up PRs as the relevant directories are added to `TestIncludesAreSorted.HOTSPOT_SOURCES_TO_CHECK`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24247#discussion_r2015912061