RFR: 8351491: Add info from release file to hserr file [v2]

[Magnus Ihse Bursie]

On Wed, 26 Mar 2025 15:11:06 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The release file of the JDK image contains useful info, for example the SOURCE used to built this image e.g.
>> SOURCE=".:git:21af8c7e7405"
>> Also the MODULES list is probably useful to have.
>> Add this info (or the complete content of the release file) to the hs_err files.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address Windows issues

My general opinion is that we should include as little information about stuff like version strings, git hashes, etc in any built binary. It just tends to trigger unnecessary rebuild chains in incremental builds, and make reproducibility harder.

I'm not even sure what to do with this one. The file is too large to be passed in its entirety as a define. So then we'd have to add yet another gensrc rule for hotspot, to integrate the contents of this file into a generated .c file. And that would mean hotspot needs to be rebuilt every time the release file changes.

TL;DR: I think that would be a bad idea. I suggested the solution currently in the patch, where the file is read at startup.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24244#issuecomment-2758084416