RFR: 8347449: C2: UseLoopPredicate off should also turn UseProfiledLoopPredicate off [v5]
Manuel Hässig
duke at openjdk.org
Fri Mar 28 09:10:01 UTC 2025
On Thu, 27 Mar 2025 14:28:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> src/hotspot/share/opto/c2_globals.hpp line 790:
>>
>>> 788: "Move checks with an uncommon trap out of loops based on " \
>>> 789: "profiling data. " \
>>> 790: "Requires UseLoopPredicate to be turned on (default).") \
>>
>> Can you also update the comment for `UseLoopPredicate`? It seems outdated / wrong.
>>
>> Now is:
>> `Generate a predicate to select fast/slow loop versions`
>>
>> @chhagedorn do you have a good suggestion for what to put now?
>
> Good catch! It could be similar but without mentioning profiling data:
>
> Move checks with an uncommon trap out of loops.
Fixed in [ca10148](https://github.com/openjdk/jdk/pull/24248/commits/ca101483aac17b0ace223df0f8a62bfd0dfa2e1f)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24248#discussion_r2018190355
More information about the hotspot-dev
mailing list