RFR: 8351040: [REDO] Protection zone for easier detection of accidental zero-nKlass use [v3]

[Thomas Stuefe]

On Thu, 27 Mar 2025 13:42:14 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8351040-REDO-Protection-zone-for-easier-detection-of-accidental-zero-nKlass-use
>>  - skip test if we have no COH archive
>>  - Merge branch 'openjdk:master' into JDK-8351040-REDO-Protection-zone-for-easier-detection-of-accidental-zero-nKlass-use
>>  - aix fix
>>  - test and aix exclusion
>>  - Fix windows when ArchiveRelocationMode=0 or 2
>>  - original
>
> src/hotspot/share/cds/archiveBuilder.cpp line 329:
> 
>> 327:   if (CDSConfig::is_dumping_static_archive()) {
>> 328:     _current_dump_region = &_pz_region;
>> 329:     _current_dump_region->init(&_shared_rs, &_shared_vs);
> 
> Second line in 'if' and 'else' seems to be identical ?

fixed

> src/hotspot/share/cds/archiveUtils.cpp line 85:
> 
>> 83: 
>> 84:   // The number of bits used by the rw/ro ptrmaps. We might have lots of zero
>> 85:   // bits at the bottom and top of rrw/ro ptrmaps, but these zeros will be
> 
> What means rrw here ?

typo; foxed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23912#discussion_r2020104442
PR Review Comment: https://git.openjdk.org/jdk/pull/23912#discussion_r2020104299