RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v11]

Mon Mar 31 11:14:14 UTC 2025

On Mon, 24 Mar 2025 02:38:37 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Ferenc Rakoczi has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Further readability improvements.
>>  - Added asserts for array sizes
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1252:
> 
>> 1250:   // Currently we only have them for AVX512
>> 1251: #ifdef _LP64
>> 1252:   if (supports_evex() && supports_avx512bw()) {
> 
> supports_evex check looks redundant.

These are checks for two different feature bits: CPU_AVX512F and CPU_AVX512BW. Are you saying that the latter implies the former in every implementation of the spec?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r2020853815