RFR: 8353217: Build libsleef on macos-aarch64

[Magnus Ihse Bursie]

On Sat, 29 Mar 2025 17:41:29 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Build and use SLEEF library as a backend implementation for Vector API trigonometric functions on macosx-aarch64 platform.
>> 
>> It improves raw throughput and eliminates GC overhead of non-intrinsified Vector API operation.
>> 
>> PR includes build changes and libsleef sources relocation from `src/jdk.incubator.vector/linux/native/` to `src/jdk.incubator.vector/share/native/`.
>> 
>> Once libsleef library is present, existing code in `stubGenerator_aarch64.cpp` successfully links at JVM startup. 
>> 
>> Testing: hs-tier1 - hs-tier4, microbenchmarks
>
> make/modules/jdk.incubator.vector/Lib.gmk line 83:
> 
>> 81:       SRC := libsleef/lib, \
>> 82:       EXTRA_SRC := libsleef/generated, \
>> 83:       DISABLED_WARNINGS_gcc := unused-function sign-compare tautological-compare ignored-qualifiers, \
> 
> DISABLED_WARNINGS_gcc is technically not needed, gcc is not a supported compiler on macOS, at least, not yet...
> 
> If you feel that gcc support for macOS is a worthy addition to have to make the lives of future compiler porters, you can leave it in there. It's otherwise up to you whether you want to remove it or not (I personally like the idea of being able to compile for macOS with gcc in the future however)

No, we should not have dead code "just in case". If someone were to support gcc on macos (seems implausible if that could ever be possible), then this is the least of their troubles.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24306#discussion_r2020917777