RFR: 8353217: Build libsleef on macos-aarch64

[Magnus Ihse Bursie]

On Mon, 31 Mar 2025 08:58:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Build and use SLEEF library as a backend implementation for Vector API trigonometric functions on macosx-aarch64 platform.
>> 
>> It improves raw throughput and eliminates GC overhead of non-intrinsified Vector API operation.
>> 
>> PR includes build changes and libsleef sources relocation from `src/jdk.incubator.vector/linux/native/` to `src/jdk.incubator.vector/share/native/`.
>> 
>> Once libsleef library is present, existing code in `stubGenerator_aarch64.cpp` successfully links at JVM startup. 
>> 
>> Testing: hs-tier1 - hs-tier4, microbenchmarks
>
> make/modules/jdk.incubator.vector/Lib.gmk line 85:
> 
>> 83:       DISABLED_WARNINGS_gcc := unused-function sign-compare tautological-compare ignored-qualifiers, \
>> 84:       DISABLED_WARNINGS_clang := unused-function sign-compare tautological-compare ignored-qualifiers, \
>> 85:       CFLAGS := $(NEON_CFLAGS), \
> 
> Is this supposed to match configs for linux-aarch64? I see we add `NEON_CFLAGS` here, and do _not_ add `vector_math_sve.c_CFLAGS` here. I would have thought those two are applicable to macos-aarch64 as well?

This seems to be resurrected from some very old code. We don't have any `NEON_CFLAGS` anymore.

This makes me wonder: @iwanowww what kind of testing have you done to ensure this works correctly?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24306#discussion_r2020922588