RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v10]

[Ferenc Rakoczi]

On Sun, 23 Mar 2025 00:26:20 GMT, Volodymyr Paprotski <vpaprotski at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 216:
>> 
>>> 214: // Zmm8-Zmm23 used as scratch registers
>>> 215: // result goes to Zmm0-Zmm7
>>> 216: static void montMulByConst128(MacroAssembler *_masm) {
>> 
>> wish the inputs and output register arrays were explicit.. easier to follow that way
>
> Looking at this function some more.. I think you could remove this function and replace it with two calls to `montMul64`?
> 
>   montMul64(xmm0_3, xmm0_3, xmm29_29, Scratch*, _masm);
>   montMul64(xmm4_7, xmm4_7, xmm29_29, Scratch*, _masm);
>   ```
> Scratch would have to be defined..

I accepted this suggestion, it really saved quite a few lines of code, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r2021150687