RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v5]

Ferenc Rakoczi duke at openjdk.org
Mon Mar 31 14:28:27 UTC 2025


On Thu, 6 Mar 2025 19:26:14 GMT, Volodymyr Paprotski <vpaprotski at openjdk.org> wrote:

>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Accepted review comments.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 409:
> 
>> 407:   __ evmovdquq(xmm29, Address(permsAndRots, 768), Assembler::AVX_512bit);
>> 408:   __ evmovdquq(xmm30, Address(permsAndRots, 832), Assembler::AVX_512bit);
>> 409:   __ evmovdquq(xmm31, Address(permsAndRots, 896), Assembler::AVX_512bit);
> 
> Matter of taste, but I liked the compactness of montmulEven; i.e. 
> 
> for (i=0; i<15; i++)
>     __ evmovdquq(xmm(17+i), Address(permsAndRots, 64*i), Assembler::AVX_512bit);

Changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23860#discussion_r2021155416


More information about the hotspot-dev mailing list