RFR: 8349211: Add support for intrusive trees to the utilities red-black tree [v16]

[Casper Norrbin]

On Fri, 28 Mar 2025 10:11:31 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   axel feedback
>
> src/hotspot/share/utilities/rbTree.inline.hpp line 502:
> 
>> 500: template <typename F>
>> 501: inline void RBTree<K, V, COMPARATOR, ALLOCATOR>::visit_range_in_order(const K& from, const K& to, F f) const {
>> 502:   assert(COMPARATOR::cmp(from, to) <= 0, "from must be less or equal to to");
> 
> Seem unfortunate to loose these assert, would be nice to find these sort of errors early.
> 
> Maybe we can have some verification functions on the tree which takes (const K& from, const K& to, const NodeType* end_node) which can dispatch to the correct COMPARATOR function.

I added asserts to check that `from <= start` and `start <= to`. As long as we find a node we can indirectly test this, since `from <= start <= to` => `from <= to`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23416#discussion_r2021193441