RFR: 8349211: Add support for intrusive trees to the utilities red-black tree [v15]

[Casper Norrbin]

On Fri, 28 Mar 2025 10:50:54 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Allow non-debug verify_self + comparator readability
>
> src/hotspot/share/utilities/rbTree.inline.hpp line 548:
> 
>> 546:     return;
>> 547:   }
>> 548: 
> 
> This could be a future enhancement. But it would be nice that if the COMPARATOR (or the NodeType) supplied a `cmp(const NodeType* a, const NodeType* b)` we could use it to check the order invariants for the children and parent.

The `cmp(const NodeType* a, const NodeType* b)` function is identical to the one you needed to give as a template to `verify_self` if you're using intrusive trees. I made that function be a part of the `COMPARATOR` template instead. Now, you supply a second `cmp` in `COMPARATOR` used for verification only, and that is used in both `verify_self` and `replace_at_cursor`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23416#discussion_r2021201495