RFR: 8353117: Crash: assert(id >= ThreadIdentifier::initial() && id < ThreadIdentifier::current()) failed: must be reasonable)

Mon Mar 31 18:48:45 UTC 2025

Please review the following fix. For the attaching thread case we are incorrectly setting the `_monitor_owner_id` after `Threads::add()` is called, i.e after the attaching thread becomes visible through a ThreadsListHandle. So if another thread calls `Threads::owning_thread_from_monitor()` in between these events and iterates through all JavaThreads looking for the owner of a given monitor, we might find this attaching thread still with a `_monitor_owner_id` of 0.
I corrected the ordering and improved verification checks. Tested in mach5 tiers1-5.

Thanks,
Patricio

-------------

Commit messages:
 - v1

Changes: https://git.openjdk.org/jdk/pull/24336/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24336&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8353117
  Stats: 30 lines in 7 files changed: 20 ins; 6 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/24336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24336/head:pull/24336

PR: https://git.openjdk.org/jdk/pull/24336