RFR: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
Calvin Cheung
ccheung at openjdk.org
Mon Mar 31 22:25:13 UTC 2025
On Mon, 31 Mar 2025 00:57:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
> I think these tests are very confusing!
>
> test/hotspot/jtreg/runtime/cds/appcds/ArchiveRelocationTest.java
>
> States
>
> > @comment the test uses -XX:ArchiveRelocationMode=1 to force relocation.
>
> but that is not what it does. It either sets -`XX:ArchiveRelocationMode=0` in the exec'd VM or it relies on the default being 1 - which is not the case if it was set directly via JTREG. So it seems to me the right, and simple, fix here is to always pass the expected `-XX:ArchiveRelocationMode` value to the exec'd VM and ignore/override whatever comes in via the command-line.
I've simplified the fix based on your suggestions. The new change contains only test changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24308#issuecomment-2767550637
More information about the hotspot-dev
mailing list