RFR: 8355627: Don't use ThreadCritical for EventLog list [v2]
Aleksey Shipilev
shade at openjdk.org
Thu May 1 06:15:45 UTC 2025
On Wed, 30 Apr 2025 20:58:59 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Thanks for this. I didn't know why Aleksey suggested it. I'll remove it.
>
> Maybe @shipilev meant `memory_order_release`? Anyway, I guess we don't need to optimize it.
I saw no point in enforcing memory ordering mode here, as it looks like we only did `ThreadCritical` for mutual exclusion. Note that we do not have a matching acquire on list traversals, so seqcst/release on list additions would be incomplete. That only reinforces my original thinking: we are riding on memory ordering given by something else, I'd guess the initialization sequence itself.
But I won't quibble, it is a very minor optimization.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24954#discussion_r2069890054
More information about the hotspot-dev
mailing list