RFR: 8355627: Don't use ThreadCritical for EventLog list [v2]
Martin Doerr
mdoerr at openjdk.org
Mon May 5 08:34:52 UTC 2025
On Sat, 3 May 2025 01:57:53 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
>> Yes we only used ThreadCritical to add to the list after the VM becomes multithreaded. The list traversals (reads) are for hs_err_pid file printing, which presumably is single threaded at that point and presumably nothing is adding to the list. I added Atomic::load() but I think it's not necessary to be a load_acquire.
>> There are only about 10 items max on this list so far, so I think performance isn't a concern either way.
>
> There is also a jcmd to print out events. In theory, that could be a problem if CAS is unordered.
Then, memory barriers on the reader's side should also be checked.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24954#discussion_r2073046694
More information about the hotspot-dev
mailing list