RFR: 8355627: Don't use ThreadCritical for EventLog list [v2]

Martin Doerr mdoerr at openjdk.org
Mon May 5 12:55:52 UTC 2025


On Mon, 5 May 2025 12:28:17 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> hm then should the readers be Atomic::load_acquire() ?
>
> The version you merged has `memory_order_conservative` order on CAS, so you don't need reader side barrier.

Looks like a Release-Consume pattern: https://en.cppreference.com/w/cpp/atomic/memory_order#Release-Consume_ordering
I think it is very likely that it works as it is. Not sure if Atomic::load is 100% safe for this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24954#discussion_r2073383889


More information about the hotspot-dev mailing list