RFR: 8350398: [s390x] Relativize initial_sp/monitors in interpreter frames
Amit Kumar
amitkumar at openjdk.org
Wed May 7 08:45:57 UTC 2025
On Thu, 20 Feb 2025 06:40:20 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
> s390x port for [JDK-8315966](https://bugs.openjdk.org/browse/JDK-8315966).
>
> This PR depends on https://github.com/openjdk/jdk/pull/23660 because index calculation macro will be added by that PR, which is being used by this one.
>
>
> // Frame slot index relative to fp
> #define _z_ijava_idx(_component) \
> (_z_ijava_state_neg(_component) >> LogBytesPerWord)
src/hotspot/cpu/s390/interp_masm_s390.cpp line 689:
> 687: stop("Z_fp is corrupted");
> 688: bind(ok);
> 689: #endif // ASSERT
Hi @RealLucy,
should I remove or keep this check here ? I wouldn't harm in release build anyway, but for debug build the size of `BTB` table will increase. Look `TemplateTable_s390.cpp` changes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23708#discussion_r2072838473
More information about the hotspot-dev
mailing list